Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _topics.py #2254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bertopic/plotting/_topics.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import numpy as np
import pandas as pd
import warnings
from umap import UMAP
from typing import List, Union
from sklearn.preprocessing import MinMaxScaler
Expand Down Expand Up @@ -56,6 +57,9 @@ def visualize_topics(
freq_df = freq_df.loc[freq_df.Topic != -1, :]
if topics is not None:
topics = list(topics)
elif len(topics) < 5:
warnings.warn("Too few topics to display.")
return
Comment on lines +60 to +62
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions:

  • What makes you choose the value of < 5 here? Is it working for 4 topics but it is for 5?
  • Should we raise an error rather than return nothing after a warning? By returning None, we might also have to change the typing.
  • Could you extend the description a bit more? Perhaps explain that we need more topics in order to properly visualize them?

elif top_n_topics is not None:
topics = sorted(freq_df.Topic.to_list()[:top_n_topics])
else:
Expand Down