Thy Warning Consumed: Clanging in Windows Part 1 (MSVC-CLANG) (#87)

MadDeCoDeR · Jun 1, 2023 · 5643aa2 · 5643aa2
1 parent 9b32a13
commit 5643aa2
Show file tree

Hide file tree

Showing 12 changed files with 41 additions and 2 deletions.
diff --git a/neo/framework/Compressor.h b/neo/framework/Compressor.h
@@ -29,6 +29,9 @@ If you have questions concerning this license or the applicable additional terms
 #ifndef __COMPRESSOR_H__
 #define __COMPRESSOR_H__
 
+#if defined(_MSC_VER) && defined(__clang__)
+#pragma clang diagnostic ignored "-Woverloaded-virtual"
+#endif
 /*
 ===============================================================================
 

diff --git a/neo/framework/DeclEntityDef.h b/neo/framework/DeclEntityDef.h
@@ -29,6 +29,10 @@ If you have questions concerning this license or the applicable additional terms
 #ifndef __DECLENTITYDEF_H__
 #define __DECLENTITYDEF_H__
 
+#if defined(_MSC_VER) && defined(__clang__)
+#pragma clang diagnostic ignored "-Woverloaded-virtual"
+#endif
+
 /*
 ===============================================================================
 

diff --git a/neo/framework/DemoFile.h b/neo/framework/DemoFile.h
@@ -31,6 +31,10 @@ If you have questions concerning this license or the applicable additional terms
 #ifndef __DEMOFILE_H__
 #define __DEMOFILE_H__
 
+#if defined(_MSC_VER) && defined(__clang__)
+#pragma clang diagnostic ignored "-Woverloaded-virtual"
+#endif
+
 /*
 ===============================================================================
 

diff --git a/neo/framework/File.h b/neo/framework/File.h
@@ -29,6 +29,10 @@ If you have questions concerning this license or the applicable additional terms
 #ifndef __FILE_H__
 #define __FILE_H__
 
+#if defined(_MSC_VER) && defined(__clang__)
+#pragma clang diagnostic ignored "-Woverloaded-virtual"
+#endif
+
 /*
 ==============================================================
 

diff --git a/neo/framework/File_SaveGame.h b/neo/framework/File_SaveGame.h
@@ -28,6 +28,10 @@ If you have questions concerning this license or the applicable additional terms
 #ifndef __FILE_SAVEGAME_H__
 #define __FILE_SAVEGAME_H__
 
+#if defined(_MSC_VER) && defined(__clang__)
+#pragma clang diagnostic ignored "-Woverloaded-virtual"
+#endif
+
 #include <zlib.h>
 
 // Listing of the types of files within a savegame package

diff --git a/neo/idlib/CmdArgs.cpp b/neo/idlib/CmdArgs.cpp
@@ -188,7 +188,7 @@ void idCmdArgs::TokenizeString( const char* text, bool keepAsStrings )
 
 		len = token.Length();
 
-		if( totalLen + len + 1 > sizeof( tokenized ) )
+		if( totalLen + len + 1ULL > sizeof( tokenized ) )
 		{
 			return;			// this is usually something malicious
 		}

diff --git a/neo/idlib/Heap.h b/neo/idlib/Heap.h
@@ -33,6 +33,10 @@ If you have questions concerning this license or the applicable additional terms
 #pragma GCC diagnostic ignored "-Wdeprecated"
 #else
 #pragma warning(disable: 4595) //GK: non-member operator new or delete functions may not be declared inline
+#if defined(__clang__)
+#pragma clang diagnostic ignored "-Wimplicit-exception-spec-mismatch"
+#pragma clang diagnostic ignored "-Winline-new-delete"
+#endif
 #endif
 /*
 ===============================================================================

diff --git a/neo/idlib/Lexer.h b/neo/idlib/Lexer.h
@@ -29,6 +29,10 @@ If you have questions concerning this license or the applicable additional terms
 #ifndef __LEXER_H__
 #define __LEXER_H__
 
+#if defined(_MSC_VER) && defined(__clang__)
+#pragma clang diagnostic ignored "-Wignored-qualifiers"
+#endif
+
 /*
 ===============================================================================
 

diff --git a/neo/idlib/geometry/DrawVert.h b/neo/idlib/geometry/DrawVert.h
@@ -46,6 +46,10 @@ If you have questions concerning this license or the applicable additional terms
 #define NORMALMAP_BYTE_TO_FLOAT( x )	VERTEX_BYTE_TO_FLOAT( x )	//( (x) - 128.0f ) * ( 1.0f / 127.0f )
 #define NORMALMAP_FLOAT_TO_BYTE( x )	VERTEX_FLOAT_TO_BYTE( x )	//idMath::Ftob( 128.0f + 127.0f * (x) + 0.5f )
 
+#if defined(_MSC_VER) && defined(__clang__)
+#pragma clang diagnostic ignored "-Wignored-qualifiers"
+#endif
+
 /*
 ================================================
 halfFloat_t

diff --git a/neo/idlib/sys/sys_intrinsics.h b/neo/idlib/sys/sys_intrinsics.h
@@ -32,6 +32,10 @@ If you have questions concerning this license or the applicable additional terms
 #if defined(USE_INTRINSICS)
 #include <emmintrin.h>
 #endif
+
+#if defined(_MSC_VER) && defined(__clang__)
+#pragma clang diagnostic ignored "-Wignored-attributes"
+#endif
 /*
 ================================================================================================
 

diff --git a/neo/sys/sys_public.h b/neo/sys/sys_public.h
@@ -33,6 +33,10 @@ If you have questions concerning this license or the applicable additional terms
 #include "../idlib/CmdArgs.h"
 #include "../idlib/precompiled.h"
 
+#if defined(_MSC_VER) && defined(__clang__)
+#pragma clang diagnostic ignored "-Wmicrosoft-enum-forward-reference"
+#endif
+
 /*
 ===============================================================================
 

diff --git a/neo/sys/win32/win_wndproc.cpp b/neo/sys/win32/win_wndproc.cpp
@@ -576,7 +576,7 @@ LONG WINAPI MainWndProc( HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam )
 			break;
 		}
 // GK: Start
-		case WM_DPICHANGED:
+		case WM_DPICHANGED: //GK: Microsoft Docs Lie??? This is available on Windows 7
 			int dpi = HIWORD(wParam);
 			// A little shortcut cheat using Microsoft's Documentation
 			switch (dpi) {