Skip to content

Commit

Permalink
Replica branch replication error fix
Browse files Browse the repository at this point in the history
This is a non-critical bug that might've replicated data of already destroyed replicas that the client wouldn't construct, but would throw warnings that they shouldn't have been replicated in the first place.
  • Loading branch information
LM-loleris committed Jun 16, 2024
1 parent 0e3e0ad commit cb7f979
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ServerScriptService/ReplicaService.lua
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,6 @@ local function ParseReplicaBranch(replica, func) -- func(replica)
func(replica)
for _, child in ipairs(replica.Children) do
ParseReplicaBranch(child, func)
func(child)
end
end

Expand Down Expand Up @@ -613,6 +612,7 @@ function Replica:SetParent(new_parent)
local replica_id_string = tostring(transfered_replica.Id)
temporary_creation_data[replica_id_string] = old_creation_data[replica_id_string]
transfered_replica._replication = new_replication -- Swapping _replication reference for reparented replicas
transfered_replica._creation_data = new_creation_data
end)
temporary_creation_data[tostring(replica_id)][4] = new_parent.Id
-- Modify creation data for top replicas:
Expand Down

0 comments on commit cb7f979

Please sign in to comment.