[WIP] Move resource id param to logger initialize #570
Conversation
agrare
force-pushed
the
move_resource_id_param_to_logger_initialize
branch
2 times, most recently
from
1a57f86 to
3666834
Compare
agrare
force-pushed
the
move_resource_id_param_to_logger_initialize
branch
from
3666834 to
d1a9849
Compare
| automation_log_wrapper.add(severity, message, progname, &block) | ||
|
|
||
| severity ||= Logger::UNKNOWN | ||
| return true if severity < @level |
There was a problem hiding this comment.
Do we want our level, or the level of our wrapped log?
(that is the whole automation_log_wrapper.send("#{severity}?") thing)
There was a problem hiding this comment.
Maybe we sync the :level from the wrapped logger when we build it initially? I don't want to add more call-outs to the 'hard-coded' log_wrapper since I want to try to drop this and just use a normal broadcast
| private | ||
|
|
||
| def add(severity, message = nil, progname = nil, &block) | ||
| automation_log_wrapper.add(severity, message, progname, &block) |
There was a problem hiding this comment.
think this wants to be after we resolve message?
Doesn't seem optimal if we message ||= yield and then have automation_log_wrapper have to do the same thing
There was a problem hiding this comment.
I was thinking of the wrapped logger had a different progname that it wanted to use this would allow that
There was a problem hiding this comment.
Plus I think this matches the existing behavior because it used to call the wrapped logger directly from def info as opposed to from add
No description provided.