Fix Bug with Introducers in Successions #4258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llowing Successions to handle nultiple animations acting on the same object after introduction
for more information, see https://pre-commit.ci
Tau-Laboratory
changed the title
Tau-Laboratory
changed the title
…m into fix-succession-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fix Issue described in #4257 It's currently only handling the case where introducers are added directly to the succession. Adding another animation group wont work
Fixed Bug in Successions causing mobjects to be added before they should have been introduced by an animation
Motivation and Explanation: Why and how do your changes improve the library?
I've extracted a private method _get_unintroduced_mobjects in the succession parent AnimationGroup. I did this to avoid duplicating the code creating the group
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist