Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-10862: Stored procedures: default values for parameters (optional parameters) #3646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iqbal-rsec
Copy link

  • The Jira issue number for this PR is: MDEV-10862

Description

Implement default values for parameters of stored routines in both default and oracle mode. Default values for cursor parameters are NOT supported yet.

The default values can be either literals or expressions. When it is an expression, it is only evaluated if the parameter has not been supplied by the caller (important if the expression has side effects).

Release Notes

Add support for default values for stored routine parameters.

How can this PR be tested?

./mysql-test/mtr sp-default-param

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

…l parameters)

Implement default values for parameters of stored routines in both default and oracle mode. Default values for cursor parameters are *NOT* supported yet.

The default values can be either literals or expressions. When it is an expression, it is only evaluated if the parameter has not been supplied by the caller (important if the expression has side effects).
Copy link
Contributor

@abarkov abarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The patch is OK.
Now according to https://mariadb.com/kb/en/mariadb-quality-development-rules/ it needs to pass our internal testing.

I've pushed it into
https://github.com/MariaDB/server/tree/bb-11.8-bar-MDEV-10862-opt-params
for this.

@cvicentiu
Copy link
Member

@abarkov as a reminder, please "merge" the PR from the WEB UI once it passes testing.

image

@cvicentiu cvicentiu added the External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements.
Development

Successfully merging this pull request may close these issues.

4 participants