MDEV-25488 thd::transaction::modified_non_trans_tables isn't set before Rows_log_event caching #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore ..
.. Rows_log_event caching.
In ROW binlog format a successful record modification in Engine
did not follow immediately to raising
THD::transaction::stmt::modified_non_trans_tables (MNTT)
flag which later led to an assert in MYSQL_BIN_LOG::write_cache(),
under the condition of an error occurred at logging Rows event into
the non-transactional cache. The assertion was correctly pointing
to the fact of no Incident event was logged which should've taken place.
To restore the correct behavior, when a non-transactional engine table
is being modified the MNTT flag must be raised at once after the engine
changed a first record. Having it UP a later error, incl one in writing
to the cache, triggers an Incident event logging and the assert
satisfaction.
The patch also covers
MDEV-35378 sequence statement does not trigger warning when mixed
transaction rolls back
|
|
|
@andrelkin same comment as: #3664 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO: fill description here
Release Notes
TODO: What should the release notes say about this change?
Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing.
How can this PR be tested?
TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended.
Consult the documentation on "Writing good test cases".
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check