Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More AOT annotations to the code from IL2072 #4363

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kant2002
Copy link
Contributor

@kant2002 kant2002 commented Dec 5, 2024

I also add MSBuild file which simplify testing with local Csla for samples. Just change condition locally, and dotnet build and other commands will pickup local Csla

Related #3347

I also add MSBuild file which simplify testing with local Csla for samples. Just change condition locally, and dotnet build and other commands will pickup local Csla
@rockfordlhotka
Copy link
Member

Thank you @kant2002 - this will have to wait for version 9.1 (or maybe 10, as it has breaking changes?).

Version 9 is about to go live, and this is too big to adopt today.

@rockfordlhotka
Copy link
Member

as it has breaking changes?

On further review of the code, maybe there are no breaking changes to the public API?

I don't understand some of the new code though - like changing Type to new(type)? What am I missing?

@kant2002
Copy link
Contributor Author

kant2002 commented Dec 6, 2024

You may take a look at this issue dotnet/runtime#110239 it shows technique which required to mark Type inside list with attributes

@rockfordlhotka rockfordlhotka marked this pull request as draft December 13, 2024 19:55
@rockfordlhotka rockfordlhotka self-requested a review December 30, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants