Skip to content

Commit

Permalink
filter_datasets -> filter_tables
Browse files Browse the repository at this point in the history
  • Loading branch information
ReubenFrankel committed Oct 4, 2024
1 parent ca8ed2c commit 712804c
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion meltano.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ plugins:
- name: google_storage_bucket
- name: filter_schemas
kind: array
- name: filter_datasets
- name: filter_tables
kind: array
loaders:
- name: target-jsonl
Expand Down
2 changes: 1 addition & 1 deletion tap_bigquery/connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def get_object_names(
schema_name,
)
]
if table_patterns := self.config.get("filter_datasets"):
if table_patterns := self.config.get("filter_tables"):
return [
o
for o in objects
Expand Down
14 changes: 7 additions & 7 deletions tap_bigquery/tap.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,19 @@ class TapBigQuery(SQLTap):
required=False,
description=(
"If an array of schema names is provided, the tap will only process "
"the specified BigQuery schemas and ignore others. If left blank, the "
"tap automatically determines ALL available BigQuery schemas."
"the specified BigQuery schemas (datasets) and ignore others. If left "
" blank, the tap automatically determines ALL available schemas."
),
),
th.Property(
"filter_datasets",
"filter_tables",
th.ArrayType(th.StringType),
required=False,
description=(
"If an array of dataset names is provided, the tap will only process "
"the specified BigQuery datasets and ignore others. If left blank, the "
"tap automatically determines ALL available BigQuery datasets. Shell "
"patterns are supported."
"If an array of table names is provided, the tap will only process "
"the specified BigQuery tables and ignore others. If left blank, the "
"tap automatically determines ALL available tables. Shell patterns are "
"supported."
),
),
).to_dict()
Expand Down
4 changes: 2 additions & 2 deletions tests/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
SAMPLE_CONFIG = {
"project_id": "",
"filter_schemas": [],
"filter_datasets": [],
"google_application_credentials": "MOCK"
"filter_tables": [],
"google_application_credentials": "MOCK",
}

def dump(sql, *multiparams, **params):
Expand Down

0 comments on commit 712804c

Please sign in to comment.