Skip to content

Commit

Permalink
Drop support for Python 3.7 (#29)
Browse files Browse the repository at this point in the history
* Bump minimum required Python version to 3.8 and remove upper constraint

* Update `poetry.lock`

* Upgrade `mypy`

* `assertEquals` removed in Python 3.12
  • Loading branch information
ReubenFrankel authored Jul 12, 2024
1 parent 7135fdd commit 583cbf5
Show file tree
Hide file tree
Showing 8 changed files with 935 additions and 667 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
strategy:
matrix:
python-version: ['3.7', '3.8', '3.9']
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
[![test](https://github.com/matatika/tap-google-sheets/actions/workflows/ci_workflow.yml/badge.svg)](https://github.com/matatika/tap-google-sheets/actions/workflows/ci_workflow.yml)
[![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/psf/black)
<a href="https://github.com/Matatika/tap-google-sheets/blob/master/LICENSE"><img alt="GitHub license" src="https://img.shields.io/github/license/Matatika/tap-google-sheets"></a>
[![Python](https://img.shields.io/static/v1?logo=python&label=python&message=3.7%20|%203.8%20|%203.9&color=blue)]()
[![Python version](https://img.shields.io/badge/dynamic/toml?url=https%3A%2F%2Fraw.githubusercontent.com%2FMatatika%2Ftap-google-sheets%2Fmaster%2Fpyproject.toml&query=tool.poetry.dependencies.python&label=python)](https://docs.python.org/3/)

This Google Sheets tap produces JSON-formatted data following the Singer spec.

Expand Down
1,584 changes: 926 additions & 658 deletions poetry.lock

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ keywords = [
license = "GNU Affero General Public License v3.0"

[tool.poetry.dependencies]
python = "<3.13,>=3.7.1"
python = "^3.8"
requests = "^2.31.0"
singer-sdk = "^0.34.1"
click = "8.0.1"
Expand All @@ -21,7 +21,7 @@ tox = "^3.24.4"
flake8 = "^3.9.2"
black = "^21.9b0"
pydocstyle = "^6.1.1"
mypy = "^0.910"
mypy = "^1.10.1"
types-requests = "^2.26.1"
isort = "^5.10.1"
responses = "^0.20.0"
Expand Down
2 changes: 1 addition & 1 deletion tap_google_sheets/tests/test_child_sheet_name_setting.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,6 @@ def test_discovered_stream_name(self):
self.assertIsInstance(test_utils.SINGER_MESSAGES[4], singer.StateMessage)

# Assert that data is sycned from the mocked response
self.assertEquals(
self.assertEqual(
test_utils.SINGER_MESSAGES[3].record, {"Column_One": "1", "Column_Two": "1"}
)
4 changes: 2 additions & 2 deletions tap_google_sheets/tests/test_ignoring_unnamed_columns.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,10 @@ def test_ignoring_unnamed_columns(self):
self.assertIsInstance(test_utils.SINGER_MESSAGES[5], singer.StateMessage)

# Assert that the second unnamed column and its values are ignored
self.assertEquals(
self.assertEqual(
test_utils.SINGER_MESSAGES[3].record, {"Column_One": "1", "Column_Two": "1"}
)

self.assertEquals(
self.assertEqual(
test_utils.SINGER_MESSAGES[4].record, {"Column_One": "2", "Column_Two": "2"}
)
2 changes: 1 addition & 1 deletion tap_google_sheets/tests/test_key_properties_setting.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@ def test_key_properties_being_set_in_stream(self):

# Assert that key_properties in tap streams equal to the setting key_properties
for stream in tap.catalog_dict.get("streams"):
self.assertEquals(
self.assertEqual(
stream.get("key_properties"), tap.config.get("key_properties")
)
2 changes: 1 addition & 1 deletion tap_google_sheets/tests/test_underscoring_column_names.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def test_underscoring_column_names(self):
self.assertIsInstance(test_utils.SINGER_MESSAGES[4], singer.StateMessage)

# Assert that column names have been underscored
self.assertEquals(
self.assertEqual(
test_utils.SINGER_MESSAGES[3].record,
{
"Column_One": "1",
Expand Down

0 comments on commit 583cbf5

Please sign in to comment.