Skip to content

Commit

Permalink
path property method should not set url_base or include the `url_…
Browse files Browse the repository at this point in the history
…base` value
  • Loading branch information
ReubenFrankel committed May 12, 2023
1 parent 77b8c4c commit bf34b60
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions tap_google_sheets/streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,12 @@ class GoogleSheetsStream(GoogleSheetsBaseStream):

child_sheet_name = None
primary_key = None
url_base = "https://sheets.googleapis.com/v4/spreadsheets"

@property
def path(self):
"""Set the path for the stream."""
self.url_base = "https://sheets.googleapis.com/v4/spreadsheets/"
path = (
self.url_base + self.config["sheet_id"] + "/values/" + self.child_sheet_name
)
return path
return f"/{self.config['sheet_id']}/values/{self.child_sheet_name}"

def parse_response(self, response: requests.Response) -> Iterable[dict]:
"""Parse response, build response back up into json, update stream schema."""
Expand Down

0 comments on commit bf34b60

Please sign in to comment.