Skip to content

Commit

Permalink
Merge pull request #4 from Matatika/3-upgrade-api-version
Browse files Browse the repository at this point in the history
Updated tap to use google ads api v9. Updated tests to relfect this c…
  • Loading branch information
DanielPDWalker authored May 12, 2022
2 parents 70ebf6e + e8e1ec2 commit f49aa9e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tap_googleads/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
class GoogleAdsStream(RESTStream):
"""GoogleAds stream class."""

url_base = "https://googleads.googleapis.com/v8"
url_base = "https://googleads.googleapis.com/v9"

records_jsonpath = "$[*]" # Or override `parse_response`.
next_page_token_jsonpath = "$.nextPageToken" # Or override `get_next_page_token`.
Expand Down
2 changes: 1 addition & 1 deletion tap_googleads/tests/test_base_credentials.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def test_googleads_sync_accessible_customers(self):

responses.add(
responses.GET,
"https://googleads.googleapis.com/v8/customers:listAccessibleCustomers",
"https://googleads.googleapis.com/v9/customers:listAccessibleCustomers",
json=test_utils.accessible_customer_return_data,
status=200,
)
Expand Down
2 changes: 1 addition & 1 deletion tap_googleads/tests/test_proxy_oauth.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def test_proxy_oauth_refresh(self):

responses.add(
responses.GET,
"https://googleads.googleapis.com/v8/customers:listAccessibleCustomers",
"https://googleads.googleapis.com/v9/customers:listAccessibleCustomers",
json=test_utils.accessible_customer_return_data,
status=200,
)
Expand Down

0 comments on commit f49aa9e

Please sign in to comment.