Skip to content

Commit

Permalink
Readme update, removed unneeded testing logging in streams
Browse files Browse the repository at this point in the history
  • Loading branch information
DanielPDWalker committed Oct 21, 2021
1 parent b9909ee commit 07e6b8a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ pipx install tap-openweathermap

## Configuration

#### Expected Env Vars
```bash
TAP_OPENWEATHERMAP_API_KEY=1234567890
TAP_OPENWEATHERMAP_CURRENT_WEATHER_CITY_NAME=london
Expand All @@ -21,12 +22,11 @@ TAP_OPENWEATHERMAP_FORECAST_WEATHER_LATTITUDE=51.5085

`api_key` is required for authentication, see the "Source Authentication and Authorization" section for how to get one.
`current_weather_city_name` is required, and the api will return current weather data for the supplied city name.

`forecast_weather_longitude` is optional, you need to provide this to get forecast data.
`forecast_weather_lattitude` is optional, you need to provide this to get forecast data.
`forecast_weather_longitude` is required, you need to provide this to get forecast data.
`forecast_weather_lattitude` is required, you need to provide this to get forecast data.

You can get the longitude and lattitude of a city by requesting its current weather, setting the city name to the ``current_weather_city_name` setting.
The longitude and lattidue will be returned as part of the curren
The longitude and lattidue will be returned as part of the current_weather_stream. To get the values for your first call just google "city_name" coords.

### Accepted Config Options

Expand Down
3 changes: 0 additions & 3 deletions tap_openweathermap/streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ def get_url_params(
params["q"] = self.config.get("current_weather_city_name")
params["appid"] = self.config.get("api_key")

self.logger.info("sfhsfuihsduisiofshduffjdisdfsjsiofdjidosj")
self.logger.info(self.config)

return params


Expand Down

0 comments on commit 07e6b8a

Please sign in to comment.