Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw better exception when duplicate keys are found #433

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

throw better exception when duplicate keys are found #433

wants to merge 1 commit into from

Conversation

refractalize
Copy link

If VDOM has duplicate keys we see this error, which doesn't explain what went wrong:

Failed to execute 'insertBefore' on 'Node': parameter 1 is not of type 'Node'

This patch detects duplicate keys and throws this error instead:

duplicate vdom key: <key>, vdom: <vdom-selector>

Where key is the duplicate key, and vdom-selector is a tag#id.class representation of the node so you can find it.

@refractalize
Copy link
Author

this should help with #409

@coveralls
Copy link

coveralls commented May 5, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 97.546% when pulling ad8686b on featurist:fix-duplicate-keys into 947ecf9 on Matt-Esch:master.

@coveralls
Copy link

coveralls commented May 5, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 97.546% when pulling ad8686b on featurist:fix-duplicate-keys into 947ecf9 on Matt-Esch:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refractalize @coveralls