work on personal branch #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwkshell
reviewed
Aug 25, 2017
| module MacroDefinitions | ||
|
|
||
| def try_to_call(method_name) | ||
| method_name_sym = method_name&.to_sym |
There was a problem hiding this comment.
method_name**&**.to_sym
That seems like a writing mistake
|
Look up the safe navigation operator. You need ruby 2.3 or newer
…On Aug 25, 2017 1:23 PM, "rb_" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/macro_definitions.rb
<#3 (comment)>
:
> @@ -0,0 +1,54 @@
+module MacroDefinitions
+
+ def try_to_call(method_name)
+ method_name_sym = method_name&.to_sym
method_name**&**.to_sym
That seems like a writing mistake
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEzWxy82dmV0RUYkTlTjzUjyTZn3t3Ldks5sby0igaJpZM4O8KbE>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will merge this stuff eventually.