Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load data using read_sdmx #59

Closed
javihern98 opened this issue Jan 21, 2025 · 0 comments · Fixed by #72
Closed

Load data using read_sdmx #59

javihern98 opened this issue Jan 21, 2025 · 0 comments · Fixed by #72
Assignees
Labels
enhancement New feature or request

Comments

@javihern98
Copy link
Contributor

javihern98 commented Jan 21, 2025

Add pysdmx dependency and update the the load_datapoints function to use read_sdmx method from pysdmx.io.

  • Ensure we can discriminate between the reading of plain csv and SDMX-CSV
  • Ensure we can read SDMX-ML data messages
  • Add a method to API called run_sdmx with this signature:
def run_sdmx(script: str, datasets: Sequence[PandasDataset]):
    .....

Note: both run and run_sdmx should accept SDMX files, but only run_sdmx should accept a PandasDataset at its signature. PandasDataset is imported from pysdmx.io.pd

Add at least the following tests:

  • Read SDMX-ML 2.1 Structure Specific
  • Read SDMX-ML 2.1 Generic
  • Read SDMX-CSV 1.0
  • Read SDMX-CSV 2.0
  • Ensure the API tests do not break when using plain CSVs
@javihern98 javihern98 added the enhancement New feature or request label Feb 10, 2025
@albertohernandez1995 albertohernandez1995 linked a pull request Feb 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants