Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

59 load data using read sdmx #72

Merged
merged 15 commits into from
Feb 17, 2025
Merged

59 load data using read sdmx #72

merged 15 commits into from
Feb 17, 2025

Conversation

albertohernandez1995
Copy link
Contributor

MAJOR CHANGES
Added a run_sdmx function that allows reading and loading SDMX-ML files to use them with the vtl-engine.

ISSUES
There was an issue at the time we load a SDMX-CSV file. Dataset attributes seems to be not being codified properly.

albertohernandez1995 and others added 12 commits January 30, 2025 12:36
@albertohernandez1995
Added pysdmx dependency
2b43530
@albertohernandez1995
Beginning implementation of pysdmx onto vtlengine
8db63ba
@albertohernandez1995
Preliminary run_sdmx function
e76efa8
@albertohernandez1995
run_sdmx function was created. to_vtl_json was modified to support py…
b0ff36d 
…sdmx Schema as DSD.
@albertohernandez1995
Added test files to preform run_sdmx function tests.
97ad642
@albertohernandez1995
Refactored files. Starting to test
1342a4f
@albertohernandez1995
Soft changes
d522fe7
@javihern98
Merge remote-tracking branch 'refs/remotes/origin/main' into 59-load-…
699ca08 
…data-using-read_sdmx

# Conflicts:
#	pyproject.toml
@javihern98
Restored poetry.lock
6c35a50
@albertohernandez1995
Added run_sdmx and to_vtl_json function test.
0f308a8
@albertohernandez1995
Added tests for SDMX 2.1 Structure Specific and Generic Structure XML…
08d9f00 
… files. Added a Semantic error which will raise when structure's datatype from sdmx datasets are not DSD or Schema.
@albertohernandez1995
ruff and mypy
cbfc9e8
@albertohernandez1995 albertohernandez1995 linked an issue Feb 13, 2025 that may be closed by this pull request
Load data using read_sdmx #59
Closed
javihern98
javihern98 requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check still several things on the code. Exception tests are still missing

javihern98
javihern98 approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks! 😊

@javihern98 javihern98 merged commit 7856dca into main Feb 17, 2025
14 checks passed
@javihern98 javihern98 deleted the 59-load-data-using-read_sdmx branch February 17, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javihern98 javihern98 javihern98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load data using read_sdmx
2 participants
@albertohernandez1995 @javihern98