improve cleanup #43
Merged
improve cleanup #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dont depend on controller to remove nodeMaintenance during cleanup as it may not operate properly. improper cleanup might affect other tests. to achieve that we delete object then remove finalizer. in addition wait for all objects to get removed from api during cleanup. Signed-off-by: adrianc <[email protected]>
Pull Request Test Coverage Report for Build 11614552354Details
💛 - Coveralls |
rollandf
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dont depend on controller to remove nodeMaintenance during cleanup as it may not operate properly. improper cleanup might affect other tests.
to achieve that we delete object then remove finalizer.
in addition wait for all objects to get removed from api during cleanup.