Skip to content

Commit

Permalink
feat: Enable JSON deserialization (#70)
Browse files Browse the repository at this point in the history
Closes #35

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
edgarrmondragon and pre-commit-ci[bot] authored Dec 22, 2023
1 parent 64a5ea6 commit 7895d1b
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions tap_athena/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,8 @@

import typing as t

import sqlalchemy
from singer_sdk import SQLConnector, SQLStream

if t.TYPE_CHECKING:
from sqlalchemy.engine import Engine


class AthenaConnector(SQLConnector):
"""The connector for SQLite.
Expand Down Expand Up @@ -38,21 +34,6 @@ def get_sqlalchemy_url(self, config: dict[str, t.Any]) -> str:
f"schema={config['schema_name']}"
)

def create_engine(self) -> Engine:
"""Create a SQLAlchemy engine.
Returns:
A SQLAlchemy engine.
"""
return sqlalchemy.create_engine(
self.sqlalchemy_url,
echo=False,
# TODO: Enable JSON serialization/deserialization.
# https://github.com/MeltanoLabs/tap-athena/issues/35
# json_serializer=self.serialize_json, # noqa: ERA001
# json_deserializer=self.deserialize_json, # noqa: ERA001
)


class AthenaStream(SQLStream):
"""The Stream class for Athena."""
Expand Down

0 comments on commit 7895d1b

Please sign in to comment.