Skip to content

Commit

Permalink
feat: Enable JSON deserialization
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon committed Nov 13, 2023
1 parent 2c3aca1 commit ef555ea
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions tap_athena/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,21 +38,6 @@ def get_sqlalchemy_url(self, config: dict[str, t.Any]) -> str:
f"schema={config['schema_name']}"
)

def create_engine(self) -> Engine:
"""Create a SQLAlchemy engine.
Returns:
A SQLAlchemy engine.
"""
return sqlalchemy.create_engine(
self.sqlalchemy_url,
echo=False,
# TODO: Enable JSON serialization/deserialization.
# https://github.com/MeltanoLabs/tap-athena/issues/35
# json_serializer=self.serialize_json, # noqa: ERA001
# json_deserializer=self.deserialize_json, # noqa: ERA001
)


class AthenaStream(SQLStream):
"""The Stream class for Athena."""
Expand Down

0 comments on commit ef555ea

Please sign in to comment.