Skip to content

Commit

Permalink
fix: Use NULLS FIRST for incremental replication (#83)
Browse files Browse the repository at this point in the history
<blockquote>
<p>The default null ordering is <code class="code">NULLS LAST</code>,
regardless of ascending or descending sort order.</p>
</blockquote>

References:
*
https://docs.aws.amazon.com/athena/latest/ug/select.html#select-parameters
* https://trino.io/docs/current/sql/select.html#order-by-clause
  • Loading branch information
edgarrmondragon authored Jan 11, 2024
1 parent 411eeba commit f1b26f5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tap_athena/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,4 @@ class AthenaStream(SQLStream):
"""The Stream class for Athena."""

connector_class = AthenaConnector
supports_nulls_first = True

0 comments on commit f1b26f5

Please sign in to comment.