Skip to content

Commit

Permalink
Merge pull request #5 from MeltanoLabs/bugfixes
Browse files Browse the repository at this point in the history
fix: various bug fixes from manual testing
  • Loading branch information
pnadolny13 authored Apr 11, 2023
2 parents 9e582d9 + 6cb520e commit 49c056d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions tap_dynamodb/aws_authenticators.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,4 +109,5 @@ def _assume_role(self, session, role_arn):
aws_access_key_id=response["Credentials"]["AccessKeyId"],
aws_secret_access_key=response["Credentials"]["SecretAccessKey"],
aws_session_token=response["Credentials"]["SessionToken"],
region_name=self.aws_default_region,
)
3 changes: 2 additions & 1 deletion tap_dynamodb/dynamo.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ def get_items_iter(
done = start_key is None
except ClientError as err:
self.logger.error(
"Couldn't scan for movies. Here's why: %s: %s",
"Couldn't scan for %s. Here's why: %s: %s",
table_name,
err.response["Error"]["Code"],
err.response["Error"]["Message"],
)
Expand Down
2 changes: 1 addition & 1 deletion tap_dynamodb/tap.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def discover_streams(self) -> list[streams.TableStream]:
"""
obj = DynamoDB(self.config)
discovered_streams = []
for table_name in obj.list_tables(self.config.get("tables")):
for table_name in self.config.get("tables") or obj.list_tables():
try:
stream = streams.TableStream(
tap=self,
Expand Down

0 comments on commit 49c056d

Please sign in to comment.