Skip to content

Commit

Permalink
refactor: various cleanup and fixes (#137)
Browse files Browse the repository at this point in the history
* fix: replication method to proper enum and remove duplicate methods (#133)

* fix replication method to proper enum and remove duplicate methods

* [pre-commit.ci] auto fixes

* use incremental constant vs string

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* refactor: replication IDs, deprecation warnings (#135)

* replication IDs, deprecation warnings, docs links updates

* [pre-commit.ci] auto fixes

* fix custom audience column joining

* [pre-commit.ci] auto fixes

* revert links

* revert another link change

* add todo links

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* exclude sort where not supported and fix one more replication_keys reference

* removed unused prepare_request_payload  method

* fix tests and broken types

* update github action test workflow

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
pnadolny13 and pre-commit-ci[bot] authored Jan 23, 2024
1 parent b737b38 commit 30db1b1
Show file tree
Hide file tree
Showing 5 changed files with 76 additions and 295 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/ci_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ jobs:
id: test_pytest
continue-on-error: false
env:
TAP_FACEBOOK_ACCESS_TOKEN: ${{ secrets.access_token }}
TAP_FACEBOOK_ACCOUNT_ID: ${{ secrets.account_id }}
TAP_FACEBOOK_API_VERSION: ${{ secrets.api_version }}
TAP_FACEBOOK_ACCESS_TOKEN: ${{ secrets.tap_facebook_access_token }}
TAP_FACEBOOK_ACCOUNT_ID: ${{ secrets.tap_facebook_account_id }}
run: |
poetry run pytest --capture=no
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -218,3 +218,4 @@ fabric.properties

# Android studio 3.1+ serialized cache file
.idea/caches/build_file_checksums.ser
.vscode/*
18 changes: 0 additions & 18 deletions tap_facebook/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,24 +93,6 @@ def get_url_params(

return params

def prepare_request_payload(
self,
context: dict | None, # noqa: ARG002
next_page_token: t.Any | None, # noqa: ARG002, ANN401
) -> dict | None:
"""Prepare the data payload for the REST API request.
By default, no payload will be sent (return None).
Args:
context: The stream context.
next_page_token: The next page index or value.
Returns:
A dictionary with the JSON body for a POST requests.
"""
return None

def validate_response(self, response: requests.Response) -> None:
"""Validate HTTP response.
Expand Down
Loading

0 comments on commit 30db1b1

Please sign in to comment.