Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommunityProfile stream and enhance error handling #20

Merged
merged 13 commits into from
Sep 23, 2021

Conversation

ericboucher
Copy link
Contributor

Adding a stream for CommunityProfile.

Enhancing error handling because fetching community/profile from the GitHub API sometimes return a 404 - Not Found. See #16 for more details.

@aaronsteers
Copy link
Contributor

@ericboucher - This is approved but it Looks like the linter is failing. Do you mind running poetry run black . and committing the result? CI runs are approved on this PR now so it should now rerun checks on each subsequent commit.

@aaronsteers
Copy link
Contributor

@ericboucher - Just an FYI - the CI tests need me to approve each time, but after one of these has merged, you would no longer be a "first time contributor" and then (I think!) CI tests will run without me pushing the button. 😄

@aaronsteers
Copy link
Contributor

LGTM! :shipit:

@aaronsteers aaronsteers merged commit 898c49b into MeltanoLabs:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants