Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up control chars from issue titles as well #232

Merged
merged 1 commit into from
Oct 2, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tap_github/repository_streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,8 @@ def post_process(self, row: dict, context: Optional[Dict] = None) -> dict:
# such chars are removed from the data before we pass it on to
# the target
row["body"] = row["body"].replace("\x00", "")
if row["title"] is not None:
row["title"] = row["title"].replace("\x00", "")

# replace +1/-1 emojis to avoid downstream column name errors.
if "reactions" in row:
Expand Down