Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sets MAX_RESULTS_LIMIT to 1000 when RepositoryStream.path is /search/repositories only #253

Merged

Conversation

merlindavies
Copy link
Contributor

This PR introduces a minor updates to the RepositoryStream class such the MAX_RESULTS_LIMIT is applied only when the path is :
/search/repositories/,
and not when it's
/repos/{org}/{repo}
or
/orgs/{org}/repos.

These last two endpoints can handle results greater than 1000.

Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @merlindavies!

@edgarrmondragon edgarrmondragon merged commit 19af00a into MeltanoLabs:main May 7, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants