Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: Bump singer-sdk to 0.35 #320

Merged
merged 2 commits into from
Dec 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test_tap.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
FORCE_COLOR: 1

jobs:
tests:

Expand Down
55 changes: 17 additions & 38 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ python-dateutil = "~=2.9"
requests = "~=2.32.3"
# For local SDK dev:
# singer-sdk = {path = "../singer-sdk", develop = true}
singer-sdk = { version = "~=0.34.0", python = "<4" }
singer-sdk = "~=0.35.0"

[tool.poetry.dev-dependencies]
pytest = ">=7.3.1"
Expand Down
20 changes: 10 additions & 10 deletions tap_github/tests/test_tap.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def test_get_a_repository_in_repo_list_mode(
)
# Verify we got the right number of records
# one per repo in the list only if we sync the "repositories" stream, 0 if not
assert captured_out.count('{"type": "RECORD", "stream": "repositories"') == len(
assert captured_out.count('{"type":"RECORD","stream":"repositories"') == len(
repo_list_2_ids * (not skip_parent_streams)
)
# check that the tap corrects invalid case in config input
Expand All @@ -138,9 +138,9 @@ def test_last_state_message_is_valid(capsys, repo_list_config): # noqa: F811
capsys, repo_list_config, "repositories", single_stream=None
)
# capture the messages we're interested in
state_messages = re.findall(r'{"type": "STATE", "value":.*}', captured_out)
state_messages = re.findall(r'{"type":"STATE","value":.*}', captured_out)
issue_comments_records = re.findall(
r'{"type": "RECORD", "stream": "issue_comments",.*}', captured_out
r'{"type":"RECORD","stream":"issue_comments",.*}', captured_out
)
assert state_messages is not None
last_state_msg = state_messages[-1]
Expand Down Expand Up @@ -184,15 +184,15 @@ def test_get_a_user_in_user_usernames_mode(
)
# Verify we got the right number of records:
# one per user in the list if we sync the root stream, 0 otherwise
assert captured_out.count('{"type": "RECORD", "stream": "users"') == len(
assert captured_out.count('{"type":"RECORD","stream":"users"') == len(
username_list_config["user_usernames"] * (not skip_parent_streams)
)
# these 2 are inequalities as number will keep changing :)
assert captured_out.count('{"type": "RECORD", "stream": "starred"') > 150
assert captured_out.count('{"type": "RECORD", "stream": "user_contributed_to"') > 25
assert '{"username": "aaronsteers"' in captured_out
assert '{"username": "aaRONsTeeRS"' not in captured_out
assert '{"username": "EricBoucher"' not in captured_out
assert captured_out.count('{"type":"RECORD","stream":"starred"') > 150
assert captured_out.count('{"type":"RECORD","stream":"user_contributed_to"') > 25
assert '{"username":"aaronsteers"' in captured_out
assert '{"username":"aaRONsTeeRS"' not in captured_out
assert '{"username":"EricBoucher"' not in captured_out


@pytest.mark.repo_list(["torvalds/linux"])
Expand All @@ -204,7 +204,7 @@ def test_large_list_of_contributors(capsys, repo_list_config): # noqa: F811
captured_out = run_tap_with_config(
capsys, repo_list_config, skip_stream=None, single_stream="contributors"
)
assert captured_out.count('{"type": "RECORD", "stream": "contributors"') == 0
assert captured_out.count('{"type":"RECORD","stream":"contributors"') == 0


def test_web_tag_parse_counter():
Expand Down
Loading