Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate 502 errors from github on issue comments #54

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Tolerate 502 errors from github on issue comments #54

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04581a8
Tolerate 502 errors from github on issue comments
laurentS Nov 24, 2021
9537778
Merge branch 'main' into temp-fix-github-timeouts
ericboucher Nov 27, 2021
c79bc54
Merge branch 'main' into temp-fix-github-timeouts
ericboucher Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tap_github/repository_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,9 @@ class IssueCommentsStream(GitHubStream):
parent_stream_type = RepositoryStream
state_partitioning_keys = ["repo", "org"]
ignore_parent_replication_key = False
# FIXME: this allows the tap to continue on server-side timeouts but means
# we have gaps in our data
tolerated_http_errors = [502]

def get_records(self, context: Optional[dict] = None) -> Iterable[Dict[str, Any]]:
"""Return a generator of row-type dictionary objects.
Expand Down