Skip to content

Commit

Permalink
fix: increase dimensions limit to 9 (#260)
Browse files Browse the repository at this point in the history
Currently this tap only allows a maximum of 7 dimensions per report,
even though the actual limit is 9.

[Docs](https://developers.google.com/analytics/devguides/reporting/data/v1/rest/v1beta/Dimension):
> Requests are allowed up to 9 dimensions.
  • Loading branch information
SuchUsernameMuchWow authored Oct 17, 2024
1 parent 983ca7b commit 00bcd46
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tap_google_analytics/tap.py
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,9 @@ def _validate_report_def(self, reports_definition):
)
sys.exit(1)

if len(dimensions) > 7: # noqa: PLR2004
if len(dimensions) > 9: # noqa: PLR2004
self.logger.critical(
"'%s' has too many dimensions defined. GA reports can have maximum 7 "
"'%s' has too many dimensions defined. GA reports can have maximum 9 "
"dimensions.",
name,
)
Expand Down

0 comments on commit 00bcd46

Please sign in to comment.