Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase dimensions limit to 9 #260

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: increase dimensions limit to 9 #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tap_google_analytics/tap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,9 @@ def _validate_report_def(self, reports_definition):
)
sys.exit(1)

if len(dimensions) > 7: # noqa: PLR2004
if len(dimensions) > 9: # noqa: PLR2004
self.logger.critical(
"'%s' has too many dimensions defined. GA reports can have maximum 7 "
"'%s' has too many dimensions defined. GA reports can have maximum 9 "
"dimensions.",
name,
)
Expand Down
Loading