feat: Use sorted API requests to support crash tolerant incremental sync #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support sorted incremental sync
JichaoS
changed the title
|
Hi @JichaoS! Thanks for contributing. Can you merge |
|
@edgarrmondragon Updated! |
|
@edgarrmondragon which API version is the secret pointing to? Can we update that to at min "2023-02-22" (which is what I've been running with) |
|
@JichaoS It's pointing to revision 2023-10-15, but you probably need to set the secrets in your fork for GH actions to pick them up. |
|
Thanks, I tested this out locally and it's WAI. Getting same results as meltanolabs/head on my test acct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The streams changed support sorted responses
Ex: https://developers.klaviyo.com/en/reference/get_campaigns
This PR takes advantage of ascending timestamps to support fault tolerant incremental syncs that picks up at the last left-off place.