Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Singer SDK version #39

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

ReubenFrankel
Copy link
Contributor

Update to the last Python 3.8-supported SDK version. The upper-Python version constrain can then be dropped (i.e. ^3.8).


Closes #28
Supersedes #35

@ReubenFrankel
Copy link
Contributor Author

Anything else worth getting in from the newer SDK here?

@edgarrmondragon
Copy link
Member

edgarrmondragon commented Dec 12, 2024

Anything else worth getting in from the newer SDK here?

  1. Might be worth adding dynamic_catalog: bool = True to the tap class:

    name = "tap-mongodb"

    from meltano/sdk@ecdfa0e

  2. Maybe emitting custom metrics that are appropriate for this tap, but that's probably out of scope and better to leave if to its own issue and PR.

@edgarrmondragon
Copy link
Member

Thanks!

@edgarrmondragon edgarrmondragon merged commit 50a8923 into MeltanoLabs:main Dec 12, 2024
17 checks passed
@ReubenFrankel ReubenFrankel deleted the update-singer-sdk branch December 12, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update singer-sdk version
2 participants