Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Test with singer-sdk @ main #198

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test: Test with singer-sdk @ main #198

wants to merge 2 commits into from

Conversation

edgarrmondragon
Copy link
Member

No description provided.

pnadolny13
pnadolny13 reviewed Oct 3, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@edgarrmondragon
Copy link
Member Author

edgarrmondragon commented Oct 3, 2023 •
edited
Loading

@pnadolny13 You may want to

  1. fetch main
  2. rebase test/main (interactively) from main
  3. squash all commits into the first one
  4. force push

@pnadolny13
Copy link

@edgarrmondragon yeah I think I fixed it - also I did test this and saw much better performance 😄

@edgarrmondragon edgarrmondragon force-pushed the test/main branch 3 times, most recently from 28deaaa to 5d4c22d Compare January 23, 2024 19:57
@edgarrmondragon edgarrmondragon force-pushed the test/main branch 2 times, most recently from 4867f04 to 997fbaf Compare April 29, 2024 17:26
@edgarrmondragon edgarrmondragon force-pushed the test/main branch 4 times, most recently from b36add4 to cc32e05 Compare July 30, 2024 20:11
@edgarrmondragon edgarrmondragon force-pushed the test/main branch 5 times, most recently from 0588e79 to 6d6b5d0 Compare August 13, 2024 23:20
@edgarrmondragon edgarrmondragon force-pushed the test/main branch 4 times, most recently from dcd7ec4 to aa338ae Compare November 28, 2024 23:26
@edgarrmondragon edgarrmondragon force-pushed the test/main branch 3 times, most recently from 992ee95 to f0aae3b Compare November 28, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnadolny13 pnadolny13 pnadolny13 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
MeltanoLabs Overview
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgarrmondragon @pnadolny13