Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latitude/Longitude lines and set_extent fix #1012

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwarner8
Copy link
Contributor

@jwarner8 jwarner8 commented Dec 18, 2024

Addresses #930 by adding latitude/longitude contours to spatial maps if spatial map.
Also fixes issue where set_extent does not work properly, by passing it the map projection.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jwarner8
Copy link
Contributor Author

TODO: ensemble applicability and catch cases where spatial coordinates are not latitude/longitude.

@jwarner8 jwarner8 self-assigned this Dec 18, 2024
@jwarner8 jwarner8 added enhancement New feature or request small Small issue that should be quick to resolve labels Dec 18, 2024
Copy link
Contributor

Coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request small Small issue that should be quick to resolve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant