Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

653 add pointstat met office configuration #1079

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

JorgeBornemann
Copy link
Collaborator

@JorgeBornemann JorgeBornemann commented Jan 27, 2025

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@JorgeBornemann JorgeBornemann linked an issue Jan 27, 2025 that may be closed by this pull request
@JorgeBornemann JorgeBornemann marked this pull request as draft January 27, 2025 09:10
Copy link
Contributor

Coverage

@JorgeBornemann
Copy link
Collaborator Author

Initial implementation of NG-VER METPlus PointStat configurations for the Met Office.

@jfrost-mo jfrost-mo marked this pull request as ready for review January 27, 2025 09:17
@jfrost-mo jfrost-mo marked this pull request as draft January 27, 2025 09:19
@jfrost-mo
Copy link
Member

Thanks Jorge, its great to see this!

I'll probably have a chance to review towards the end of the week, so let me know if there is anything to pay particular attention to.

@JorgeBornemann
Copy link
Collaborator Author

At the moment is just sanity check of the workflow structure and the apps/wrappers. If you think it is sound, it will need someone from the Met Office who has access to the observations and forecasts files to take it over, finish the coding and test thoroughly. Any change beyond the Met Office specific files, I need to be aware of it, as it will impact other sites.

@JorgeBornemann
Copy link
Collaborator Author

One thing to pay special attention to is whether there is in this branch information that should go in the restricted repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PointStat Met Office configuration
2 participants