919 plot vertical line series and plot scatter plot add cubelist handling #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiple cases. Fixes #1048
This handles globbing anywhere in the input path, moves to treating the provided patterns as strings rather than paths before they have been resolved, and generally makes the path and file loading more consistently handled. Also included is marking the first path loaded as comparison base, which will be used by difference operators to know what to compare against. In practice this will translate to the first model in the GUI being used as the base.
This reflects the non-sequential nature of the variable, and how it will soon contain multiple values.
This change switches to a generated rose-meta.conf, so it is much easier to maintain. It also removes a number of obsolete keys, updates descriptions, makes analysis_offset and analysis_period per-model, and removes the s/crimes against rose edit/mapping between model and fieldname/. One of the biggest changes is the move to a simple list for model fields instead of the complicated table affair we had before. Fixes #667 Fixes #808 Fixes #817 Fixes #859 Update example rose-suite.conf
This will cause it to be marked as such on GitHub, and not clutter up pull request diffs.
This allows comparing different variables from the same plot.
Most of the time this is what you want. You only need to set the offset if data isn't output on the first timestep.
Use PT1H as that is what a lot of data is output at. Urban data is often 15 minutely, but is sufficiently niche to require changing an accessible setting.
Also tweak a few help descriptions.
Co-authored-by: James Frost <[email protected]>
into a new operator as now needed in multiple operators
due to collapsing over wrong time coordinate
Co-authored-by: James Frost <[email protected]>
Co-authored-by: James Frost <[email protected]>
This required adding some LFRic test data. This is a small cutout over Exeter from an LFRic_apps vn1.1 run valid for 20220101T0000Z.
We instead just use the order of the latitude coordinate, which is what we care about anyway.
We no longer need it, and ideally want code to be model agnostic.
This adds a number of new variables taken from UKEP Plot's def_atm_vars.py. This also includes a large number of difference ranges. The existing range values have been preserved where they were difference with the exception of cloud base height, which has been increased to a more reasonable sounding 1000m.
This fixes the flaky tests that have come from caplog picking up a different tests logs now we are running under pytest-xdist.
…g in vertical line plotting operator.
|
In order to get the plot operator working with lfric data I had to change the recipe for plotting on mlevels. this rquired changing the coordinate set to full_levels |
|
|
|
Due to rebasing main and then merging in those changes into my branch there are a lot of changes to review. the main change is in def _plot_and_save_vertical_line_series( |
|
Updating branch as this might help. |
Sylviabohnenstengel
changed the title
|
used GitHub Copilot to include cubelists in zip function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.