Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend histogram plot with CubeList handling capability #1116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Extend histogram plot with CubeList handling capability #1116

wants to merge 2 commits into from

Conversation

Sylviabohnenstengel
Copy link
Contributor

@Sylviabohnenstengel Sylviabohnenstengel commented Feb 3, 2025 •
edited
Loading

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@Sylviabohnenstengel Sylviabohnenstengel self-assigned this Feb 3, 2025
@Sylviabohnenstengel Sylviabohnenstengel mentioned this pull request Feb 3, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

Coverage

@Sylviabohnenstengel Sylviabohnenstengel linked an issue Feb 3, 2025 that may be closed by this pull request
plot.plot_histogram_series should be able to handle a CubeList #917
Open
@Sylviabohnenstengel
Copy link
Contributor Author

ready to review, but recipe needs changingt o test with pressure levels. We will also want to be able to choose full_levels, half_levels and mdoel_level_number with the recipes for lfric and um, respectively.

@Sylviabohnenstengel Sylviabohnenstengel marked this pull request as ready for review February 3, 2025 18:04
jwarner8
jwarner8 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@jwarner8 jwarner8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This reminds me I have some work in PR #1008 which makes plots easier to read (and exception for rainfall rate in using log, log axis). Once this is merged I'll rebase that branch and get it in review.

jfrost-mo
jfrost-mo reviewed Feb 6, 2025
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good. Just a small changed needed to ensure we still plot something when the stamp_coordinate doesn't exist.

src/CSET/operators/plot.py Outdated Show resolved Hide resolved
@jfrost-mo jfrost-mo changed the title extend histogram plot with CubeList handling capability. Extend histogram plot with CubeList handling capability Feb 6, 2025
@Sylviabohnenstengel
Copy link
Contributor Author

@jfrost-mo not sure what causes the failed test with the suggested change? DO you have an idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrost-mo jfrost-mo jfrost-mo left review comments

@jwarner8 jwarner8 jwarner8 approved these changes

Assignees

@Sylviabohnenstengel Sylviabohnenstengel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plot.plot_histogram_series should be able to handle a CubeList
3 participants
@Sylviabohnenstengel @jwarner8 @jfrost-mo