-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add configuration and workflow for container build #108
Conversation
@twsearle interesting concept 👍🏽 lets see if we have enough gas to archive the packages (I don't know if there is a limit). Couple of minor thoughts:
|
I tried this but I couldn't get it to work - the dockerfile generated had an incorrect path to download hdf5. You can see this if you diff the dockerfiles with this one. Happy to do it this way if you can get it working? I dont have an azure/ec2 box with root access to experiment... perhaps I should get one.
XD I thought |
Oh in terms of the package archiving, orca-jedi is open so as far as I know, its packages are free. |
@yaswant on the hdf5 issue, It might be worth me opening a ticket with HPCCM? I believe this is the offending line: and should read:
I will ask in the hpccm repo and see what they say. |
NVIDIA/hpc-container-maker#488 opened an issue and PR with the container maker here. |
We are aware of this, see https://github.com/MetOffice/jopa-container/commit/c61f023c0913fdd8d1eb36f44b5e078d8b8969b8 where we are now pointing to hdf5 GitHub to build the library instead of using default hpccm recipe. Glad that you have opened an issue with hpccm. |
Ahh great thanks sorry I didn't see that change! I have put up the recipe as part of this PR. I will now make the adaptation to use automake and hpccm instead of just docker to build the container image. |
@yaswant is this any better? |
The plan would be to only build a package about once a tag, and they are very easy to housekeep. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming that once this PR goes in and successfully push the Docker image, you will have another PR to use the image from GHCR instead of JCSDA image.
Yep that was my thinking! I was thinking about this overnight, and perhaps it would have been better to make this change inside JOPA containers? I will put it here for now but let me know and we can just migrate it over in a new PR if that is best. |
Description
We need to update the version of the atlas library used by the CI. To do this independently of JCSDA we need to be able to build our own container containing the base image for the ci to run.
This change is the first of 4 small changes:
This container is based on the one found in jopa-containers. There were a few fixes needed (hdf5 has moved url slightly, and I removed some libraries and lfric/um packages to speed up and shrink down the container size).
Issues
/issues/109
Impact
Expected impact on downstream repositories or workflows:
Testing
https://github.com/twsearle/orca-jedi/actions/runs/10151112706
https://github.com/twsearle/orca-jedi/actions/runs/10161039329/job/28098666428