Update ci container #117
Merged
Update ci container #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good thanks for sorting this. (I'll admit the coding norms are my fault which I'll sort). |
twsearle
added a commit
that referenced
this pull request
Oct 10, 2024
) * Add 3DVar and error covariance toolbox (dirac test) main programs. * Add interpolator increment apply and adjoint methods and add increment to state method. * Update ci container (#117) * Add reference data for 3dvar and dirac application tests. Turn off creation of json schema again for 3dvar and errorcovariancetoolbox applications. Co-authored-by: Toby Searle <[email protected]>
twsearle
added a commit
that referenced
this pull request
Nov 20, 2024
* Add 3DVar and error covariance toolbox (dirac test) main programs. * Add initial version of 3dvar and dirac ctest. * Add saber to citest. * Another attempt to fix CI test. Add state tofieldset test. * Fixes to yaml files. Dirac test working. 3DVar needs adjoint interpolator adding. * Add interpolator increment apply and adjoint methods and add increment to state method. Update yaml 3DVar yaml file so 3DVar runs through (but produces nans currently). * Initial attempt to implement an increment interpolator unit test. * Fixes to new interpolator unit tests. * interpolator adjoint deal with missing values. * Add some additional code to respect fillvalues. * Update ci container (#117) * Update ci container * allow manual trigger of ci * temporary change to force ci to run * revert temporary change as ci now gets past cmake config step * Fix coding norms. * Tidying up. * Fix a merge error. * Apply suggestions from code review Co-authored-by: Toby Searle <[email protected]> * Update copyrights. * Add reference data for 3dvar and dirac application tests. Turn off creation of json schema again for 3dvar and errorcovariancetoolbox applications. * Update 3dvar 3dvar 3dvar minimizer to DRPCG as recommended. * Rename ice to sic to match other tests etc. * Add BUMP NICA grid calculation. Change to use BUMP background error correlations in Dirac and 3DVar. * Add BUMP NICA grid calculation. Change to use BUMP background error correlations in Dirac and 3DVar. * Add BUMP NICA grid calculation. Change to use BUMP background error correlations in Dirac and 3DVar. * Add BUMP NICA grid calculation. Change to use BUMP background error correlations in Dirac and 3DVar. * Remove old 3dvar yaml file. * Changes to allow increments to deal with fillvalues produced by BUMP. * Temporary fix to new atlas error about non-linear interpolation. Add some input data to the repo so the tests work. * Make masking out duplicate points for bump more generic. * Change bump settings to make test for setting up grid quicker. Attempt to revert change to not use missing-if-all-missing in atlas interpolator. * Filter out all observations with missing values in the innovations. Temporary fix for "Adjoint interpolation only works for interpolation schemes that are linear" error in 3dvar. * Updates to fix atlas adjoint interpolation error message. * Add bump nicas test reference data. Add units tests. Tidy up code/comments. * Add support for missing values to more increment methods. * Bug fix to missing value detection. * Add identity 3dvar test (old test). Add some halo exchanges when going from increments to fieldset and vice versa. * Change fill value. * Update fill value * Apply suggestions from code review Co-authored-by: Toby Searle <[email protected]> * Changes in response to review. In particular removing the unneeded custom routine to determine the i and j points. * Add a bit more info to comment about extra field area. * Add a description to the set_gmask (set geometry mask) optional parameter. --------- Co-authored-by: Toby Searle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes to the underlying CI container to incorporate qhull as well as adding vader to the ci workflow. (both are requirements for building saber).
This change ought to be capable of getting saber built and tested. So far my workflow run on this only gives me a failure on the coding norms test: