Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated oops classes #127

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Dec 27, 2024

Description

Remove all shared description of OOPS base class parameters. Please check the docs or get in touch with the developers of OOPS to find out what base class parameters are required as they change from this point forward.

Issue(s) addressed

Resolves orca-jedi component of https://github.com/orgs/JCSDA-internal/discussions/163

Impact

Should have zero effect as we are not using variable changes or linear variable changes, and we are maintaining our own validation of these parameters.

Checklist

  • I have linted my code using cpplint
  • I have run the unit tests
  • I have run mo-bundle to check integration with the rest of JEDI and run the unit tests under all environments

@twsearle twsearle force-pushed the feature/param_free_incr branch from b086d18 to cbba57e Compare December 27, 2024 11:57
@twsearle twsearle requested a review from s-good December 27, 2024 12:52
@twsearle twsearle self-assigned this Dec 27, 2024
@twsearle
Copy link
Collaborator Author

twsearle commented Jan 7, 2025

This change has to be merged by tomorrow, could I please get a review?

@twsearle twsearle merged commit ba116db into develop Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants