Remove deprecated oops classes #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsearle
force-pushed
the
feature/param_free_incr
branch
from
b086d18 to
cbba57e
Compare
|
This change has to be merged by tomorrow, could I please get a review? |
matthewrmshin
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove all shared description of OOPS base class parameters. Please check the docs or get in touch with the developers of OOPS to find out what base class parameters are required as they change from this point forward.
Issue(s) addressed
Resolves orca-jedi component of https://github.com/orgs/JCSDA-internal/discussions/163
Impact
Should have zero effect as we are not using variable changes or linear variable changes, and we are maintaining our own validation of these parameters.
Checklist