Add increment code needed for 3DVar #88
Conversation
setup most increments class methods needed for DA and add unit tests for them.
|
A new mo-bundle test is now running see http://fcm1/cylc-review/cycles/frld/?suite=mo-bundle-orca-jedi-increment3 |
| @@ -105,6 +105,8 @@ class State : public util::Printable, | |||
| const oops::Variables & variables() const {return vars_;} | |||
| oops::Variables & variables() {return vars_;} | |||
|
|
|||
| atlas::Field getField(int) const; | |||
There was a problem hiding this comment.
Sorry, I just realised one more thing - this one won't be tested. Could you please add a test to src/tests/orca-jedi/test_state.cc just to retrieve a field and check its name matches what is expected? I can help with this if needed.
There was a problem hiding this comment.
I'll give it a go and let you know if I'm stumped.
There was a problem hiding this comment.
I've added a basic test. Does it fit the bill?
These all passed except for a few lfric tests which run out of wallclock. This is a known issue unrelated to my developments. |
Description
This adds some of the increments class methods needed for data assimilation (DA) to orca-jedi and updates the increments unit test to test this. **NB this is continuation of PR #85
This PR doesn't including all the increments methods needed for DA in particular I left out the (netcdf) writing code, I'll put this in a later PR. I have also attempted to minimise the changes to other parts of the code in this PR. I'm hoping this means it is not too big to review.
FYI my draft list for PRs below
Currently this code only works for single processor runs. I was hoping to leave implementing multiprocessing for a future PR.
Also I am aware that both the increments methods and state methods operate on atlas fieldsets so there is the possibility of calling generic methods for both increment and state using a generic fields class. I note this approach is used by lfric and also oops/l95 and probably other code in JEDI. Let me know if you have any thoughts on this. It might be nice to do this in orcajedi too, but ideally not this PR. I think it would be helpful to get the increment test (along with my initial code) in place first.
Issue(s) addressed
N/A
Dependencies
N/A
Impact
There is no impact on other code as far I am aware.
Checklist