Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split keyring-api #24

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

refactor: split keyring-api #24

wants to merge 13 commits into from

Conversation

ccharly
Copy link
Collaborator

@ccharly ccharly commented Sep 9, 2024 •
edited
Loading

Description

Split of the keyring-api into smaller packages.

@ccharly ccharly force-pushed the refactor/split-keyring-api branch 5 times, most recently from 4678982 to 55f15b4 Compare September 10, 2024 19:46
@ccharly
Copy link
Collaborator Author

ccharly commented Sep 10, 2024

@metamaskbot publish-preview

1 similar comment
@ccharly
Copy link
Collaborator Author

ccharly commented Sep 11, 2024

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/keyring-api": "8.1.0-67f3b77",
  "@metamask-previews/eth-hd-keyring": "7.0.1-67f3b77",
  "@metamask-previews/eth-ledger-bridge-keyring": "4.1.1-67f3b77",
  "@metamask-previews/eth-simple-keyring": "6.0.2-67f3b77",
  "@metamask-previews/eth-trezor-keyring": "3.1.0-67f3b77",
  "@metamask-previews/keyring-internal-api": "0.0.1-67f3b77",
  "@metamask-previews/eth-snap-keyring": "4.3.2-67f3b77",
  "@metamask-previews/keyring-snap-client": "0.0.1-67f3b77",
  "@metamask-previews/keyring-snap-sdk": "0.0.1-67f3b77",
  "@metamask-previews/keyring-utils": "0.0.1-67f3b77"
}

@ccharly
Copy link
Collaborator Author

ccharly commented Sep 11, 2024

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/keyring-api": "8.1.0-672cc7b",
  "@metamask-previews/eth-hd-keyring": "7.0.1-672cc7b",
  "@metamask-previews/eth-ledger-bridge-keyring": "4.1.1-672cc7b",
  "@metamask-previews/eth-simple-keyring": "6.0.2-672cc7b",
  "@metamask-previews/eth-trezor-keyring": "3.1.0-672cc7b",
  "@metamask-previews/keyring-internal-api": "0.0.1-672cc7b",
  "@metamask-previews/eth-snap-keyring": "4.3.2-672cc7b",
  "@metamask-previews/keyring-snap-client": "0.0.1-672cc7b",
  "@metamask-previews/keyring-snap-sdk": "0.0.1-672cc7b",
  "@metamask-previews/keyring-utils": "0.0.1-672cc7b"
}

@ccharly ccharly marked this pull request as ready for review September 13, 2024 08:40
@ccharly ccharly requested a review from a team as a code owner September 13, 2024 08:40
This was referenced Sep 13, 2024
Draft
Closed
@ccharly
Copy link
Collaborator Author

ccharly commented Sep 13, 2024

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/keyring-api": "8.1.0-b9b21be",
  "@metamask-previews/eth-hd-keyring": "7.0.1-b9b21be",
  "@metamask-previews/eth-ledger-bridge-keyring": "4.1.1-b9b21be",
  "@metamask-previews/eth-simple-keyring": "6.0.2-b9b21be",
  "@metamask-previews/eth-trezor-keyring": "3.1.0-b9b21be",
  "@metamask-previews/keyring-internal-api": "0.0.1-b9b21be",
  "@metamask-previews/eth-snap-keyring": "4.3.2-b9b21be",
  "@metamask-previews/keyring-snap-client": "0.0.1-b9b21be",
  "@metamask-previews/keyring-snap-sdk": "0.0.1-b9b21be",
  "@metamask-previews/keyring-utils": "0.0.1-b9b21be"
}

@github-actions GitHub Actions
Copy link

This PR is marked as stale because it has been open for 60 days with no activity. Please remove the stale label or leave a comment, or it will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 18, 2024
@danroc danroc removed the Stale label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccharly @danroc