Skip to content

feat(identity): sync address book contacts #5776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7a3e790
feat(identity): sync address book
fabiobozzo May 7, 2025
9ff5c3a
revert AddressBookController additions to this branch
fabiobozzo May 8, 2025
bf927ce
try to list local contacts for syncing
fabiobozzo May 13, 2025
eb6ca55
implement address book sync scenarios
fabiobozzo May 14, 2025
f695eef
misc fixes and controller-integration test
fabiobozzo May 16, 2025
0be1bf3
cleanup comments
fabiobozzo May 16, 2025
80696e6
address-book-syncing complete unit tests
fabiobozzo May 19, 2025
9bab13d
Merge branch 'main' into feat/backup-and-sync-contacts
fabiobozzo May 19, 2025
d26f607
do not store timestamps and tombstone to address book local entries
fabiobozzo May 19, 2025
69bab9a
revert unwanted package.json changes
fabiobozzo May 20, 2025
5f29e56
Merge branch 'main' into feat/backup-and-sync-contacts
fabiobozzo May 20, 2025
6400a78
changelog
fabiobozzo May 20, 2025
55863e0
fix: yarn.lock
mathieuartu May 20, 2025
4620f41
fix lint errors
fabiobozzo May 20, 2025
52006a2
refactor into contact-syncing with semaphore
fabiobozzo May 22, 2025
f355d95
AddressBookController: fix bug and test lastUpdatedAt
fabiobozzo May 22, 2025
b20201e
fix controller-integrations.test.ts
fabiobozzo May 22, 2025
5d94073
Merge branch 'main' into feat/backup-and-sync-contacts
fabiobozzo May 22, 2025
bf2d58b
align AddressBookController to events PR
fabiobozzo May 22, 2025
0b20c61
missing allowedEvents in createCustomUserStorageMessenger
fabiobozzo May 22, 2025
26ae925
copycat the address-book-controller changelog to make ci pass
fabiobozzo May 22, 2025
358c5fd
Merge branch 'main' into feat/backup-and-sync-contacts
fabiobozzo May 23, 2025
f961f56
changelog entries
fabiobozzo May 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions eslint-warning-thresholds.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
"packages/accounts-controller/src/AccountsController.test.ts": {
"import-x/namespace": 1
},
"packages/address-book-controller/src/AddressBookController.ts": {
"jsdoc/check-tag-names": 13
},
"packages/approval-controller/src/ApprovalController.test.ts": {
"import-x/order": 1,
"jest/no-conditional-in-test": 16
Expand Down
10 changes: 10 additions & 0 deletions packages/address-book-controller/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,21 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Add `AddressBookControllerContactUpdatedEvent` and `AddressBookControllerContactDeletedEvent` types for contact events ([#5779](https://github.com/MetaMask/core/pull/5779))
- Add `list` method on `AddressBookController` to get all address book entries as an array ([#5779](https://github.com/MetaMask/core/pull/5779))
- Register message handlers for `list`, `set`, and `delete` actions ([#5779](https://github.com/MetaMask/core/pull/5779))

### Changed

- Bump `@metamask/base-controller` from ^8.0.0 to ^8.0.1 ([#5722](https://github.com/MetaMask/core/pull/5722))
- Bump `@metamask/controller-utils` to `^11.9.0` ([#5583](https://github.com/MetaMask/core/pull/5583), [#5765](https://github.com/MetaMask/core/pull/5765), [#5812](https://github.com/MetaMask/core/pull/5812))

### Fixed

- Fix `delete` method to clean up empty chainId objects when the last address in a chain is deleted ([#5779](https://github.com/MetaMask/core/pull/5779))

## [6.0.3]

### Changed
Expand Down
Loading
Loading