Skip to content

feat(address-book): messaging updated and deleted events #5779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

fabiobozzo
Copy link

@fabiobozzo fabiobozzo commented May 8, 2025

Explanation

  • Emit events on contact updates and deletions.
  • List method to retrieve contacts stored locally.

References

Needed by: #5776

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@fabiobozzo fabiobozzo marked this pull request as ready for review May 22, 2025 11:35
@fabiobozzo fabiobozzo requested review from a team as code owners May 22, 2025 11:35
@MetaMask MetaMask deleted a comment from github-actions bot May 22, 2025
@fabiobozzo
Copy link
Author

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "29.0.0-preview-748e5947",
  "@metamask-previews/address-book-controller": "6.0.3-preview-748e5947",
  "@metamask-previews/announcement-controller": "7.0.3-preview-748e5947",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-748e5947",
  "@metamask-previews/approval-controller": "7.1.3-preview-748e5947",
  "@metamask-previews/assets-controllers": "63.0.0-preview-748e5947",
  "@metamask-previews/base-controller": "8.0.1-preview-748e5947",
  "@metamask-previews/bridge-controller": "26.0.0-preview-748e5947",
  "@metamask-previews/bridge-status-controller": "23.0.0-preview-748e5947",
  "@metamask-previews/build-utils": "3.0.3-preview-748e5947",
  "@metamask-previews/chain-agnostic-permission": "0.7.0-preview-748e5947",
  "@metamask-previews/composable-controller": "11.0.0-preview-748e5947",
  "@metamask-previews/controller-utils": "11.9.0-preview-748e5947",
  "@metamask-previews/delegation-controller": "0.3.0-preview-748e5947",
  "@metamask-previews/earn-controller": "0.14.0-preview-748e5947",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-748e5947",
  "@metamask-previews/ens-controller": "16.0.0-preview-748e5947",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-748e5947",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-748e5947",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-748e5947",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-748e5947",
  "@metamask-previews/keyring-controller": "22.0.0-preview-748e5947",
  "@metamask-previews/logging-controller": "6.0.4-preview-748e5947",
  "@metamask-previews/message-manager": "12.0.1-preview-748e5947",
  "@metamask-previews/multichain": "4.1.0-preview-748e5947",
  "@metamask-previews/multichain-api-middleware": "0.3.0-preview-748e5947",
  "@metamask-previews/multichain-network-controller": "0.7.0-preview-748e5947",
  "@metamask-previews/multichain-transactions-controller": "1.0.0-preview-748e5947",
  "@metamask-previews/name-controller": "8.0.3-preview-748e5947",
  "@metamask-previews/network-controller": "23.5.0-preview-748e5947",
  "@metamask-previews/notification-services-controller": "8.0.0-preview-748e5947",
  "@metamask-previews/permission-controller": "11.0.6-preview-748e5947",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-748e5947",
  "@metamask-previews/phishing-controller": "12.5.0-preview-748e5947",
  "@metamask-previews/polling-controller": "13.0.0-preview-748e5947",
  "@metamask-previews/preferences-controller": "18.0.0-preview-748e5947",
  "@metamask-previews/profile-sync-controller": "15.0.0-preview-748e5947",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-748e5947",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-748e5947",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-748e5947",
  "@metamask-previews/sample-controllers": "0.1.0-preview-748e5947",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-748e5947",
  "@metamask-previews/signature-controller": "29.0.0-preview-748e5947",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-748e5947",
  "@metamask-previews/transaction-controller": "56.2.0-preview-748e5947",
  "@metamask-previews/user-operation-controller": "35.0.0-preview-748e5947"
}

@fabiobozzo
Copy link
Author

Should be verified by: MetaMask/metamask-extension#33116

Copy link
Contributor

@mathieuartu mathieuartu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very solid work! Added some comments, LMK if you need anything!

@fabiobozzo fabiobozzo requested a review from mathieuartu May 22, 2025 14:38
Copy link
Contributor

@mathieuartu mathieuartu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Fabio! 🛹🛹🛹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants