Skip to content

chore: adds new initialize method and cleans constructor #5781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented May 8, 2025

Explanation

We are removing the async call that existed in the constructor and moving it to a initialize method, the goal is to not have side-effects such as this call inside a constructor.

References

Ref slack conversation.
https://github.com/MetaMask/accounts-planning/issues/927

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@zone-live zone-live marked this pull request as ready for review May 20, 2025 14:55
@zone-live zone-live requested review from a team as code owners May 20, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant