Skip to content

feat: add lending functionality to controller #5828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: add lending functionality to controller #5828

wants to merge 3 commits into from

Conversation

nickewansmith
Copy link
Contributor

@nickewansmith nickewansmith commented May 19, 2025 •
edited
Loading

Explanation

  • What is the current state of things and why does it need to change?
  • Currently we do not have lending functionality in the earn controller. We want to be able to control pooled staking and lending from one source such that we can extend to extension easily
  • What is the solution your changes offer and how does it work?
  • updates earn sdk to latest
  • adds lending api methods and helpers
  • adds lending contract methods and helpers
  • adds multichain for pooled staking state
  • Are there any changes whose purpose might not obvious to those unfamiliar with the domain?
  • No I don't think so
  • If your primary goal was to update one package but you found you had to update another one along the way, why did you do so?
    • n/a
  • If you had to upgrade a dependency, why did you do so?
  • We need the latest stake-sdk to use lending functionality

References

Fixes https://consensyssoftware.atlassian.net/browse/STAKE-904

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@nickewansmith nickewansmith force-pushed the STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller branch 3 times, most recently from e98615a to cf6f81f Compare May 19, 2025 22:18
@socket-security Socket Security
Copy link

socket-security bot commented May 19, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updated@​metamask/​stake-sdk@​1.0.0 ⏵ 3.0.086 +110094 +197 +4100

View full report

@nickewansmith nickewansmith force-pushed the STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller branch 2 times, most recently from dd2a4d6 to 6a84ad7 Compare May 19, 2025 22:49
@nickewansmith
Copy link
Contributor Author

@metamaskbot publish-preview

@nickewansmith
feat: add lending functionality to controller
37f78da 
- updates earn sdk to latest
- adds lending api methods and helpers
- adds lending contract methods and helpers
- adds multichain for pooled staking state
@nickewansmith nickewansmith force-pushed the STAKE-904-add-deposit-withdraw-execution-helpers-and-state-in-earn-controller branch from 6a84ad7 to 37f78da Compare May 20, 2025 00:36
@nickewansmith nickewansmith marked this pull request as ready for review May 20, 2025 00:41
@nickewansmith nickewansmith requested review from a team as code owners May 20, 2025 00:41
@nickewansmith
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "29.0.0-preview-37f78da",
  "@metamask-previews/address-book-controller": "6.0.3-preview-37f78da",
  "@metamask-previews/announcement-controller": "7.0.3-preview-37f78da",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-37f78da",
  "@metamask-previews/approval-controller": "7.1.3-preview-37f78da",
  "@metamask-previews/assets-controllers": "63.0.0-preview-37f78da",
  "@metamask-previews/base-controller": "8.0.1-preview-37f78da",
  "@metamask-previews/bridge-controller": "25.1.0-preview-37f78da",
  "@metamask-previews/bridge-status-controller": "21.0.0-preview-37f78da",
  "@metamask-previews/build-utils": "3.0.3-preview-37f78da",
  "@metamask-previews/chain-agnostic-permission": "0.7.0-preview-37f78da",
  "@metamask-previews/composable-controller": "11.0.0-preview-37f78da",
  "@metamask-previews/controller-utils": "11.9.0-preview-37f78da",
  "@metamask-previews/delegation-controller": "0.3.0-preview-37f78da",
  "@metamask-previews/earn-controller": "0.14.0-preview-37f78da",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-37f78da",
  "@metamask-previews/ens-controller": "16.0.0-preview-37f78da",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-37f78da",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-37f78da",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-37f78da",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-37f78da",
  "@metamask-previews/keyring-controller": "22.0.0-preview-37f78da",
  "@metamask-previews/logging-controller": "6.0.4-preview-37f78da",
  "@metamask-previews/message-manager": "12.0.1-preview-37f78da",
  "@metamask-previews/multichain": "4.1.0-preview-37f78da",
  "@metamask-previews/multichain-api-middleware": "0.3.0-preview-37f78da",
  "@metamask-previews/multichain-network-controller": "0.7.0-preview-37f78da",
  "@metamask-previews/multichain-transactions-controller": "1.0.0-preview-37f78da",
  "@metamask-previews/name-controller": "8.0.3-preview-37f78da",
  "@metamask-previews/network-controller": "23.5.0-preview-37f78da",
  "@metamask-previews/notification-services-controller": "8.0.0-preview-37f78da",
  "@metamask-previews/permission-controller": "11.0.6-preview-37f78da",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-37f78da",
  "@metamask-previews/phishing-controller": "12.5.0-preview-37f78da",
  "@metamask-previews/polling-controller": "13.0.0-preview-37f78da",
  "@metamask-previews/preferences-controller": "18.0.0-preview-37f78da",
  "@metamask-previews/profile-sync-controller": "15.0.0-preview-37f78da",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-37f78da",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-37f78da",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-37f78da",
  "@metamask-previews/sample-controllers": "0.1.0-preview-37f78da",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-37f78da",
  "@metamask-previews/signature-controller": "29.0.0-preview-37f78da",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-37f78da",
  "@metamask-previews/transaction-controller": "56.1.0-preview-37f78da",
  "@metamask-previews/user-operation-controller": "35.0.0-preview-37f78da"
}

@nickewansmith
Copy link
Contributor Author

@metamaskbot publish-preview

@nickewansmith nickewansmith marked this pull request as draft May 21, 2025 11:16
@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "29.0.0-preview-7bb49dcb",
  "@metamask-previews/address-book-controller": "6.0.3-preview-7bb49dcb",
  "@metamask-previews/announcement-controller": "7.0.3-preview-7bb49dcb",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-7bb49dcb",
  "@metamask-previews/approval-controller": "7.1.3-preview-7bb49dcb",
  "@metamask-previews/assets-controllers": "63.0.0-preview-7bb49dcb",
  "@metamask-previews/base-controller": "8.0.1-preview-7bb49dcb",
  "@metamask-previews/bridge-controller": "25.1.0-preview-7bb49dcb",
  "@metamask-previews/bridge-status-controller": "22.0.0-preview-7bb49dcb",
  "@metamask-previews/build-utils": "3.0.3-preview-7bb49dcb",
  "@metamask-previews/chain-agnostic-permission": "0.7.0-preview-7bb49dcb",
  "@metamask-previews/composable-controller": "11.0.0-preview-7bb49dcb",
  "@metamask-previews/controller-utils": "11.9.0-preview-7bb49dcb",
  "@metamask-previews/delegation-controller": "0.3.0-preview-7bb49dcb",
  "@metamask-previews/earn-controller": "0.14.0-preview-7bb49dcb",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-7bb49dcb",
  "@metamask-previews/ens-controller": "16.0.0-preview-7bb49dcb",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-7bb49dcb",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-7bb49dcb",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-7bb49dcb",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-7bb49dcb",
  "@metamask-previews/keyring-controller": "22.0.0-preview-7bb49dcb",
  "@metamask-previews/logging-controller": "6.0.4-preview-7bb49dcb",
  "@metamask-previews/message-manager": "12.0.1-preview-7bb49dcb",
  "@metamask-previews/multichain": "4.1.0-preview-7bb49dcb",
  "@metamask-previews/multichain-api-middleware": "0.3.0-preview-7bb49dcb",
  "@metamask-previews/multichain-network-controller": "0.7.0-preview-7bb49dcb",
  "@metamask-previews/multichain-transactions-controller": "1.0.0-preview-7bb49dcb",
  "@metamask-previews/name-controller": "8.0.3-preview-7bb49dcb",
  "@metamask-previews/network-controller": "23.5.0-preview-7bb49dcb",
  "@metamask-previews/notification-services-controller": "8.0.0-preview-7bb49dcb",
  "@metamask-previews/permission-controller": "11.0.6-preview-7bb49dcb",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-7bb49dcb",
  "@metamask-previews/phishing-controller": "12.5.0-preview-7bb49dcb",
  "@metamask-previews/polling-controller": "13.0.0-preview-7bb49dcb",
  "@metamask-previews/preferences-controller": "18.0.0-preview-7bb49dcb",
  "@metamask-previews/profile-sync-controller": "15.0.0-preview-7bb49dcb",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-7bb49dcb",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-7bb49dcb",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-7bb49dcb",
  "@metamask-previews/sample-controllers": "0.1.0-preview-7bb49dcb",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-7bb49dcb",
  "@metamask-previews/signature-controller": "29.0.0-preview-7bb49dcb",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-7bb49dcb",
  "@metamask-previews/transaction-controller": "56.1.0-preview-7bb49dcb",
  "@metamask-previews/user-operation-controller": "35.0.0-preview-7bb49dcb"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nickewansmith