Skip to content

fix: remove leading zeroes in authorization list #5830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented May 20, 2025

Explanation

Remove leading zeroes in authorizationList properties, specifically r, s, yParity and nonce.

References

Relates to #32928

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthewwalsh0 matthewwalsh0 force-pushed the fix/authorization-leading-zeroes branch from e14218e to d20538b Compare May 20, 2025 11:53
@matthewwalsh0
Copy link
Member Author

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "29.0.0-preview-d20538b",
  "@metamask-previews/address-book-controller": "6.0.3-preview-d20538b",
  "@metamask-previews/announcement-controller": "7.0.3-preview-d20538b",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-d20538b",
  "@metamask-previews/approval-controller": "7.1.3-preview-d20538b",
  "@metamask-previews/assets-controllers": "63.0.0-preview-d20538b",
  "@metamask-previews/base-controller": "8.0.1-preview-d20538b",
  "@metamask-previews/bridge-controller": "25.1.0-preview-d20538b",
  "@metamask-previews/bridge-status-controller": "21.0.0-preview-d20538b",
  "@metamask-previews/build-utils": "3.0.3-preview-d20538b",
  "@metamask-previews/chain-agnostic-permission": "0.7.0-preview-d20538b",
  "@metamask-previews/composable-controller": "11.0.0-preview-d20538b",
  "@metamask-previews/controller-utils": "11.9.0-preview-d20538b",
  "@metamask-previews/delegation-controller": "0.3.0-preview-d20538b",
  "@metamask-previews/earn-controller": "0.14.0-preview-d20538b",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-d20538b",
  "@metamask-previews/ens-controller": "16.0.0-preview-d20538b",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-d20538b",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-d20538b",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-d20538b",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-d20538b",
  "@metamask-previews/keyring-controller": "22.0.0-preview-d20538b",
  "@metamask-previews/logging-controller": "6.0.4-preview-d20538b",
  "@metamask-previews/message-manager": "12.0.1-preview-d20538b",
  "@metamask-previews/multichain": "4.1.0-preview-d20538b",
  "@metamask-previews/multichain-api-middleware": "0.3.0-preview-d20538b",
  "@metamask-previews/multichain-network-controller": "0.7.0-preview-d20538b",
  "@metamask-previews/multichain-transactions-controller": "1.0.0-preview-d20538b",
  "@metamask-previews/name-controller": "8.0.3-preview-d20538b",
  "@metamask-previews/network-controller": "23.5.0-preview-d20538b",
  "@metamask-previews/notification-services-controller": "8.0.0-preview-d20538b",
  "@metamask-previews/permission-controller": "11.0.6-preview-d20538b",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-d20538b",
  "@metamask-previews/phishing-controller": "12.5.0-preview-d20538b",
  "@metamask-previews/polling-controller": "13.0.0-preview-d20538b",
  "@metamask-previews/preferences-controller": "18.0.0-preview-d20538b",
  "@metamask-previews/profile-sync-controller": "15.0.0-preview-d20538b",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-d20538b",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-d20538b",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-d20538b",
  "@metamask-previews/sample-controllers": "0.1.0-preview-d20538b",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-d20538b",
  "@metamask-previews/signature-controller": "29.0.0-preview-d20538b",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-d20538b",
  "@metamask-previews/transaction-controller": "56.1.0-preview-d20538b",
  "@metamask-previews/user-operation-controller": "35.0.0-preview-d20538b"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant