test: throw on foundryup installation issues #32641

davidmurdoch · 2025-05-07T18:58:13Z

Description

We now throw if an existing anvil install cannot be removed in order to install a new one.

Additionally, we now throw on installation errors and on the cleanup step in order to reveal problems with filesystem access. The new errors can look something like this (I had to had to mess with the file system in order to get it to error multiple ways at once):

Error: AggregateError: This is a bug; you should report it.
    at extractFrom (/home/david/code/metamask-extension/test/helpers/foundry/extract.ts:98:13)
    at async checkAndDownloadBinaries (/home/david/code/metamask-extension/test/helpers/foundry/foundryup.ts:96:7)
    at async downloadAndInstallFoundryBinaries (/home/david/code/metamask-extension/test/helpers/foundry/foundryup.ts:173:30) {
  [errors]: [
    Error: ENOTEMPTY: directory not empty, rename '/home/david/code/metamask-extension/.metamask/cache/e8263365c086121ae7aba67089b92654b5c38a8c27f0562c4d1b6ba97100f4fa.downloading' -> '/home/david/code/metamask-extension/.metamask/cache/e8263365c086121ae7aba67089b92654b5c38a8c27f0562c4d1b6ba97100f4fa'
        at async rename (node:internal/fs/promises:782:10)
        at async extractFrom (/home/david/code/metamask-extension/test/helpers/foundry/extract.ts:79:5)
        at async checkAndDownloadBinaries (/home/david/code/metamask-extension/test/helpers/foundry/foundryup.ts:96:7)
        at async downloadAndInstallFoundryBinaries (/home/david/code/metamask-extension/test/helpers/foundry/foundryup.ts:173:30) {
      errno: -39,
      code: 'ENOTEMPTY',
      syscall: 'rename',
      path: '/home/david/code/metamask-extension/.metamask/cache/e8263365c086121ae7aba67089b92654b5c38a8c27f0562c4d1b6ba97100f4fa.downloading',
      dest: '/home/david/code/metamask-extension/.metamask/cache/e8263365c086121ae7aba67089b92654b5c38a8c27f0562c4d1b6ba97100f4fa'
    },
    [Error: ENOTDIR: not a directory, scandir '/home/david/code/metamask-extension/.metamask/cache/e8263365c086121ae7aba67089b92654b5c38a8c27f0562c4d1b6ba97100f4fa/anvil'] {
      errno: -20,
      code: 'ENOTDIR',
      syscall: 'scandir',
      path: '/home/david/code/metamask-extension/.metamask/cache/e8263365c086121ae7aba67089b92654b5c38a8c27f0562c4d1b6ba97100f4fa/anvil'
    }
  ]
}

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-05-07T18:58:35Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

davidmurdoch · 2025-05-07T19:13:54Z

test/helpers/foundry/extract.ts

    // if things fail for any reason try to clean up a bit. it is very important
    // to not leave `dir` behind, as its existence is a signal that the binaries
    // are installed.
-    await Promise.all([rm(tempDir, rmOpts), rm(dir, rmOpts)]).catch(noop);
-    throw e;
+    const rmErrors = (


same logic as before, but ALSO throws errors for the clean up rm calls.

davidmurdoch · 2025-05-07T19:14:25Z

test/helpers/foundry/extract.ts

+    // this directory shouldn't exist, but if two simultaneous `yarn foundryup`
+    // processes are running, it might. Last process wins, so we remove other
+    // `dir`s just in case.
+    await rm(dir, rmOpts);


This change might prevent rename issues, even though it should be impossible to get into this function is dir already exists.

metamaskbot · 2025-05-07T19:41:30Z

Builds ready [42a87e6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1230 ± 68 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1230	1114	1499	68	1278	1354
			load	1077	966	1255	62	1109	1220
			domContentLoaded	1070	948	1250	63	1102	1213
			domInteractive	17	14	49	5	16	25
			firstPaint	713	84	1264	435	1087	1214
			backgroundConnect	8	4	54	6	7	21
			firstReactRender	21	15	60	7	22	36
			getState	16	6	42	9	22	32
			initialActions	0	0	1	0	0	1
			loadScripts	823	717	987	60	858	952
			setupStore	8	5	23	3	9	15
	Webpack	Home	uiStartup	2173	1713	2566	172	2302	2385
			load	1691	1326	2004	130	1758	1927
			domContentLoaded	1685	1322	1998	129	1754	1923
			domInteractive	16	11	72	11	13	45
			firstPaint	159	61	331	58	178	282
			backgroundConnect	29	9	364	36	34	51
			firstReactRender	170	54	385	111	301	357
			getState	14	4	163	22	15	27
			initialActions	3	1	6	1	4	5
			loadScripts	1680	1321	1975	129	1753	1900
			setupStore	19	7	266	26	21	33
Firefox	Browserify	Home	uiStartup	1353	1173	1784	117	1414	1572
			load	1206	1039	1573	108	1272	1431
			domContentLoaded	1206	1039	1573	108	1272	1431
			domInteractive	97	37	191	26	103	147
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	138	16	20	32
			firstReactRender	23	19	57	7	23	35
			getState	11	4	219	23	8	22
			initialActions	0	0	1	0	0	1
			loadScripts	1187	1025	1541	107	1254	1381
			setupStore	6	4	24	3	6	10
	Webpack	Home	uiStartup	1602	1417	2250	175	1674	2015
			load	1368	1203	1905	144	1458	1648
			domContentLoaded	1368	1203	1904	144	1457	1647
			domInteractive	82	38	241	27	91	126
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	27	15	296	28	26	48
			firstReactRender	37	30	63	6	39	49
			getState	10	5	47	7	10	32
			initialActions	0	0	1	0	1	1
			loadScripts	1345	1184	1773	136	1436	1622
			setupStore	18	5	585	65	9	32

Benchmark value 1077 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1070 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 1220 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1214 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1215 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 953 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 18 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2015 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 24ms | Sum of p95 exceeds: 200ms
Sum of all benchmark exceeds: 224ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -7.34 KiB (-0.14%)
ui: 67.74 KiB (0.96%)
common: -19.99 KiB (-0.21%)

metamaskbot · 2025-05-10T01:37:10Z

Builds ready [d3c5cfe]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1246 ± 93 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1246	1089	1551	93	1287	1461
			load	1082	952	1371	80	1116	1251
			domContentLoaded	1075	948	1366	80	1111	1240
			domInteractive	17	13	45	4	17	26
			firstPaint	693	81	1375	440	1086	1232
			backgroundConnect	9	3	31	5	8	22
			firstReactRender	20	15	51	7	20	37
			getState	15	5	41	8	22	32
			initialActions	0	0	1	0	0	1
			loadScripts	828	702	1096	73	865	962
			setupStore	7	5	14	2	8	11
	Webpack	Home	uiStartup	2170	1760	2501	167	2292	2389
			load	1680	1375	2154	132	1758	1905
			domContentLoaded	1674	1372	2150	131	1754	1895
			domInteractive	15	11	53	8	13	41
			firstPaint	160	62	310	56	186	286
			backgroundConnect	27	10	91	15	32	65
			firstReactRender	172	53	373	106	286	352
			getState	15	4	319	31	15	25
			initialActions	3	1	6	1	4	5
			loadScripts	1669	1370	2140	131	1748	1879
			setupStore	20	6	299	29	22	33
Firefox	Browserify	Home	uiStartup	1351	1167	1943	126	1420	1582
			load	1204	1051	1799	115	1278	1422
			domContentLoaded	1203	1051	1799	115	1278	1422
			domInteractive	102	49	181	25	115	153
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	67	9	21	42
			firstReactRender	24	20	56	6	24	37
			getState	8	4	38	5	8	16
			initialActions	0	0	1	0	0	1
			loadScripts	1185	1037	1770	114	1254	1391
			setupStore	10	4	462	46	6	11
	Webpack	Home	uiStartup	1564	1374	2154	144	1633	1881
			load	1339	1179	1898	132	1407	1600
			domContentLoaded	1339	1179	1897	132	1407	1599
			domInteractive	82	35	318	31	85	133
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	14	61	7	23	36
			firstReactRender	36	30	50	5	38	46
			getState	12	5	275	27	9	25
			initialActions	0	0	2	1	1	1
			loadScripts	1319	1163	1875	132	1384	1584
			setupStore	8	5	25	3	8	16

Benchmark value 1247 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1083 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1075 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1461 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1251 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1241 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1232 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 22 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 962 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore
Sum of mean exceeds: 42ms | Sum of p95 exceeds: 296ms
Sum of all benchmark exceeds: 338ms

Bundle size diffs

background: 0 Bytes (0%)
ui: 0 Bytes (0%)
common: 0 Bytes (0%)

davidmurdoch · 2025-05-14T23:09:09Z

moved to MetaMask/core#5810

test: throw on foundryup installation issues

5f70b0d

metamaskbot added the team-extension-platform Extension Platform team label May 7, 2025

davidmurdoch added 3 commits May 7, 2025 15:03

put the change back

04ba1a2

remove assert

856e7e4

p to r (for result)

42a87e6

davidmurdoch commented May 7, 2025

View reviewed changes

Merge branch 'main' into foundryuperrorlogging

d3c5cfe

davidmurdoch closed this May 14, 2025

github-actions bot locked and limited conversation to collaborators May 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: throw on foundryup installation issues #32641

test: throw on foundryup installation issues #32641

Uh oh!

davidmurdoch commented May 7, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 7, 2025

Uh oh!

davidmurdoch May 7, 2025

Uh oh!

davidmurdoch May 7, 2025

Uh oh!

metamaskbot commented May 7, 2025

Uh oh!

metamaskbot commented May 10, 2025

Uh oh!

davidmurdoch commented May 14, 2025

Uh oh!

Uh oh!

test: throw on foundryup installation issues #32641

test: throw on foundryup installation issues #32641

Uh oh!

Conversation

davidmurdoch commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented May 7, 2025

Uh oh!

davidmurdoch May 7, 2025

Choose a reason for hiding this comment

Uh oh!

davidmurdoch May 7, 2025

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented May 7, 2025

Uh oh!

metamaskbot commented May 10, 2025

Uh oh!

davidmurdoch commented May 14, 2025

Uh oh!

Uh oh!

davidmurdoch commented May 7, 2025 •

edited

Loading