-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
test: Adding e2e tests for bridge #15067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
49546a7
to
e997697
Compare
4c9245b
to
5b30199
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds two new end-to-end tests for bridging tokens in Mobile, covering both ETH (Mainnet) to ETH (Base) and ETH (Mainnet) to SOL (Solana) scenarios. It also introduces supporting constants, selectors, page objects, mocks, and fixture updates to enable these tests.
- Updated fixture configuration for Ganache network (see fixture-builder.js).
- Added constants, selectors, and page objects to support bridge tests.
- Integrated new mocks and tests for validating the bridge flow.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
e2e/specs/confirmations/send-to-contract-address.spec.js | Removed the buildPermissions parameter from the Ganache network fixture. |
e2e/specs/bridge/costants.js | Added bridge test constants (note potential filename typo). |
e2e/specs/bridge/bridge-mocks.js | Added and updated mock handling for bridge API endpoints. |
e2e/specs/bridge/bridge-action-smoke.spec.js | Introduced end-to-end tests for ETH-to-Base and ETH-to-SOL bridging. |
e2e/selectors/Transactions/ActivitiesView.selectors.js | Updated selectors to include bridge transaction details. |
e2e/selectors/Bridge/QuoteView.selectors.js | Added selectors specific to the Bridge Quote view. |
e2e/pages/wallet/WalletActionsBottomSheet.js | Added a bridge button getter and tap method. |
e2e/pages/wallet/TokenOverview.js | Added a bridge button getter and tap action. |
e2e/pages/wallet/AddAccountBottomSheet.js | Included methods for adding a Solana account. |
e2e/pages/Transactions/ActivitiesView.js | Added helper methods for generating bridge activity labels. |
e2e/pages/Bridge/QuoteView.js | Created a page object for the Bridge Quote view with corresponding actions. |
e2e/fixtures/fixture-builder.js | Updated the Ganache network function to accept a parameterized chainId. |
Comments suppressed due to low confidence (1)
e2e/specs/bridge/costants.js:1
- The filename 'costants.js' appears to be misspelled; consider renaming it to 'constants.js' for improved clarity.
export const localNodeOptions = {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it would be too much at this point but is it possible to convert some of the new files into typescript?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Lgtm
Done |
|
|
@davibroc Congratulations! Yeah, this is the first TypeScript file in the mobile repo! I noticed something during the review in Copilot (not urgent): The filename costants.js appears to be misspelled. Consider renaming it to constants.js for improved clarity. |
Description
This PR adds two Bridge tests to Mobile:
Solana-e2e.1.mov
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist