Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes sdk terminate when accountsChanged comes in empty #1148

Merged
merged 1 commit into from
Nov 28, 2024
Merged

chore: removes sdk terminate when accountsChanged comes in empty #1148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions packages/sdk/src/services/MetaMaskSDK/InitializerManager/setupExtensionPreferences.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,9 @@
}

if (isExtensionActive && (accounts as string[])?.length === 0) {
instance.terminate().catch((error) => {
logger(
`[MetaMaskSDK: setupExtensionPreferences()] Error terminating`,
error,
);
});
logger(

Check warning on line 83 in packages/sdk/src/services/MetaMaskSDK/InitializerManager/setupExtensionPreferences.ts

View check run for this annotation

Codecov / codecov/patch

packages/sdk/src/services/MetaMaskSDK/InitializerManager/setupExtensionPreferences.ts#L83 

Added line #L83 was not covered by tests
`[MetaMaskSDK: setupExtensionPreferences()] permissions were revoked on extension or extension was locked`,
);
}
},
);
Expand Down
Loading